Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGlmnet varimp fix 2 #190
Glmnet varimp fix 2 #190
Conversation
|
The Travis error also occurs on master. |
|
Yup. @topepo it looks like our builds are failing on master. The relevant errors: checking dependencies in R code ... WARNING
'::' or ':::' import not declared from: ‘rARPACK’* checking tests ...
Running ‘testthat.R’
ERROR
Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
warning = function(c) invokeRestart("muffleWarning"))
2: eval(code, new_test_environment)
3: eval(expr, envir, enclos)
4: caret:::parse_sampling(i) at test_sampling_options.R:14
5: checkInstall(pkgs)
6: stop()
testthat results ================================================================The warning is solved with a simple addition of The error occurs in the test_sampling_options.R test. |
|
@strongh Sorry for taking so long to merge this in. Can you sync your PR and resolve any conflicts? |
|
@topepo looks like it worked. |
|
Can you remove the |
|
@topepo it has been made so. |
|
Thanks for the fix! |
|
|
See previous thread: #173