Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding MAE as a standard output for regression tasks #657

Merged
merged 3 commits into from Jul 7, 2017

Conversation

@hadjipantelis
Copy link
Contributor

@hadjipantelis hadjipantelis commented May 13, 2017

Regression tasks out-of-the-box are showing only RMSE and R^2; MAE has been added. Given that a lot of algorithms working with L1 norms I think it will be beneficial for users to immediately be able to check absolute errors too. L1 is not some arcane specialised norm and I think adding MAE to the defaults will save valuable time (and potential bugs) for people writing their own cost functions to add MAE-like measures.

@topepo
Copy link
Owner

@topepo topepo commented May 13, 2017

Can you add a note on this to News.Rd?

@hadjipantelis
Copy link
Contributor Author

@hadjipantelis hadjipantelis commented May 13, 2017

There is no section for the next/next release and I am unaware of the version numbering you would like to use. Would you like me to create a section for Changes in version 6.0-77 and take it from there? Should I change the DESCRIPTION file to indicate 6.0-77 too? (or any other version number is appropriate)

@topepo
Copy link
Owner

@topepo topepo commented May 13, 2017

Would you like me to create a section for Changes in version 6.0-77 and take it from there?

yes.

Should I change the DESCRIPTION file to indicate 6.0-77 too? (or any other version number is appropriate)

yes, thanks

@hadjipantelis
Copy link
Contributor Author

@hadjipantelis hadjipantelis commented May 14, 2017

No problem. Suggestions implemented.

@topepo topepo merged commit 7fce592 into topepo:master Jul 7, 2017
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@topepo
Copy link
Owner

@topepo topepo commented Jul 7, 2017

Thanks!

topepo added a commit that referenced this pull request Jul 8, 2017
@daniel-althoff
Copy link

@daniel-althoff daniel-althoff commented Feb 16, 2018

Hello.
I've trying adding MBE and NSE as well to the outcome... but couldn't make it happen..
could you help me out please?
Thanks

@topepo
Copy link
Owner

@topepo topepo commented Feb 16, 2018

Go ahead and file a separate issue and carefully read the instructions on the issue package to create a reproducible example. Also, in the issue, please define MBE and NSE (nonstandard evaluation?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.