Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix `preProcess` for simple data #679
Merged
Conversation
Adding MAE as a standard output for regression tasks
Fixing error message
|
Thanks! Can you add a note in the NEWS.Rd file to reflect the fix? |
|
Sure. |
Move optimism bootstrap routine to its own function
|
Can you do a quick sync and resolve the conflict in the news file? |
|
Thanks again. |
topepo
merged commit 04a3d80
into
topepo:master
1 check was pending
1 check was pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
preProcessdoesn't work properly when the transformations inpreProcessare related to individual columns only (e.g. whenmethodlist is equal tolist(center="y", ignore="x")inside this function) . This is because the piece of code inpreProcess.Rfile (lines 279-285) transforms themethodlist into a vector in such case and this change of type is not what further operations in the code expect. As a result, execution of line 357 ends up with error$ operator is invalid for atomic vectorswhen test in filetest_preProcess_internals.Ris run.This pull request fixes this problem by disallowing the implicit change of the type.