Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse requireNamespace instead of require #701
Merged
Conversation
instead of require
replace the use of require by explicit namespace
Tests pass except for elm.R gbm.R GFS.GCCL.R GFS.Thrift.R monmlp.R oblique.tree.R ranger.R svmRadial.R Note that there is an issue with the adaptive_boot resampling scheme...
|
I'm testing...
import::from(mboost, bbs, .into = "mboost")Should |
|
Indeed! I have modified the two models in which I had to use import. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Dear Max,
I've finally made it. Here is a pull request in which each require has been replaced by requireNamespace and each model has been modified accordingly. It pass all the tests except the ones for elm, GFS.GCCL, GFS.Thrift and ranger. Noe that I had to fix a typo in adaptive.R...
Please feel free to comment. I can rewrite the commits if you find them to monolitic...
Erwan