Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdding minNode functionality of 'ranger' and 'Rborist' #732
Conversation
Codecov Report
@@ Coverage Diff @@
## master #732 +/- ##
==========================================
- Coverage 16.97% 16.97% -0.01%
==========================================
Files 90 90
Lines 13185 13187 +2
==========================================
Hits 2238 2238
- Misses 10947 10949 +2
Continue to review full report at Codecov.
|
|
Looks good. Can you add an exit to the |
|
Cool. Yes; Side-note: |
Yes, please. I got those in at the end and didn't document it. |
|
No problem; done. Also added some missing |
|
Thanks! |
Both 'ranger' and 'Rborist' offer the option to control the minimum node size. This is convenient to control under/over-fitting in a natural way. All test in
RegressionTests/Codework fine.Side note: One of the
test_reg_randfolds inRborist.Rproduced a warning because when splitting a very small sample for CV one of the folds is too small andRboristerred - this run produced anNAbut I think it is a "good thing"; it is irrational to use very strong regularisation with very small training sets (<= 20).