Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More statistics for function thresholder #938

Merged
merged 5 commits into from Nov 15, 2018
Merged

More statistics for function thresholder #938

merged 5 commits into from Nov 15, 2018

Conversation

@BenjaK
Copy link
Contributor

@BenjaK BenjaK commented Sep 7, 2018

The function thresholder currently computes Sensitivity, Specificity, Youden's J and the distance to the best possible cutoff. However, these may not be the metrics that the user wishes to compare models by.

Internally, thresholder uses caret::confusionMatrix which calculates a bunch of other statistics, but throws away all but those above. This pull request enables the user to choose which statistics to compute for each probability cutoff, the options being the same as those calculated in caret::confusionMatrix. The default option calculates all statistics from caret::confusionMatrix.

@codecov-io
Copy link

@codecov-io codecov-io commented Sep 7, 2018

Codecov Report

Merging #938 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #938      +/-   ##
==========================================
- Coverage   19.54%   19.51%   -0.03%     
==========================================
  Files          90       90              
  Lines       12077    12093      +16     
==========================================
  Hits         2360     2360              
- Misses       9717     9733      +16
Impacted Files Coverage Δ
R/thresholder.R 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 464500b...19a10ab. Read the comment docs.

@topepo topepo merged commit 22866d9 into topepo:master Nov 15, 2018
2 of 3 checks passed
2 of 3 checks passed
codecov/project 19.51% (-0.03%) compared to 464500b
Details
codecov/patch Coverage not affected when comparing 464500b...19a10ab
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@topepo
Copy link
Owner

@topepo topepo commented Nov 15, 2018

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.