Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix bug in zv & corr preProcess #966
Merged
Conversation
In preProcess with methods "zv" and "corr", if there is zero variance variable to remove, it must be taken into account for correlation computation, otherwise correlation fails to compute.
nothing more, just more compact syntax
Codecov Report
@@ Coverage Diff @@
## master #966 +/- ##
=======================================
Coverage 19.54% 19.54%
=======================================
Files 90 90
Lines 12075 12075
=======================================
Hits 2360 2360
Misses 9715 9715Continue to review full report at Codecov.
|
|
Thanks. I'm going to add the additional step of adding the "zv" method when anyone chooses "corr" in the |
topepo
added a commit
that referenced
this pull request
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
In preProcess with methods "zv" and "corr", if there is zero variance variable to remove, it must be taken into account for correlation computation, otherwise correlation fails to compute.