Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load-test-client #3

Merged
merged 4 commits into from May 6, 2019

Conversation

Projects
None yet
2 participants
@ghostec
Copy link
Collaborator

commented May 3, 2019

This PR adds a new cmd "load-test" that sends random events over a configurable time interval.

Settings:

  • threads: number of parallel clients sending events
  • duration: time interval during which messages will be sent
  • randSleepCeilingMs: ceiling for random interval between successive messages
  • randPropsSize: small, medium, large, jumbo; determine ceiling for random number of keys in event

Other changes:

  • Upgraded librdkafka from 0.11.3 to 1.0.0
  • Minor naming changes were made unrelated to load-test-client.
@felipejfc
Copy link
Contributor

left a comment

Load test client could benefit from being multi-thread, the parallelism could be configurable


// loadTestClient represents the testclient command
var loadTestClient = &cobra.Command{
Use: "load-test-client",

This comment has been minimized.

Copy link
@felipejfc

felipejfc May 3, 2019

Contributor

nit: load-test-client is kinda boring to write, we could use something simpler as 'load-test"

This comment has been minimized.

Copy link
@ghostec

ghostec May 5, 2019

Author Collaborator

done

@@ -30,7 +30,7 @@ import (

// testClient represents the testclient command
var testClient = &cobra.Command{
Use: "testclient",
Use: "test-client",

This comment has been minimized.

Copy link
@felipejfc

felipejfc May 3, 2019

Contributor

nit: rename to cli-producer

This comment has been minimized.

Copy link
@ghostec

ghostec May 5, 2019

Author Collaborator

done

@ghostec

This comment has been minimized.

Copy link
Collaborator Author

commented May 5, 2019

@felipejfc Added "threads" setting to control number of parallel clients.

@ghostec ghostec force-pushed the feature/load-test-client branch from 89c1254 to d0173a3 May 5, 2019

@ghostec ghostec force-pushed the feature/load-test-client branch from d0173a3 to 7eb100a May 5, 2019

@felipejfc

This comment has been minimized.

Copy link
Contributor

commented May 5, 2019

great @ghostec

@ghostec ghostec force-pushed the feature/load-test-client branch from 94bc4e5 to cc000c0 May 6, 2019

@ghostec ghostec merged commit a0211a2 into master May 6, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.