Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add static legacy API to allow for easier migration to v2 #183

Merged
merged 5 commits into from Sep 1, 2021
Merged

Re-add static legacy API to allow for easier migration to v2 #183

merged 5 commits into from Sep 1, 2021

Conversation

felippeduran
Copy link
Member

This MR addresses issue #164

@felippeduran felippeduran changed the base branch from master to v2 April 20, 2021 20:58
@felippeduran
Copy link
Member Author

felippeduran commented Apr 23, 2021 •
edited

@leohahn, can you help me identify if there is any static API missing?

@felippeduran felippeduran mentioned this pull request May 14, 2021
Closed
@felippeduran felippeduran marked this pull request as ready for review May 14, 2021 17:16
@coveralls
Copy link

coveralls commented May 18, 2021 •
edited

Pull Request Test Coverage Report for Build 1187603567

  • 134 of 152 (88.16%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.8%) to 68.899%
Changes Missing Coverage Covered Lines Changed/Added Lines %
session/static.go 0 18 0.0%
Totals Coverage Status
Change from base Build 1148533345: 0.8%
Covered Lines: 5133
Relevant Lines: 7450
💛 - Coveralls

@henriqueoelze henriqueoelze added this to the v2 milestone Jul 28, 2021
@henriqueoelze henriqueoelze requested review from henriqueoelze and removed request for leonardo2204 and leohahn August 24, 2021 18:37
@felippeduran felippeduran changed the title Re-add static legacy API to allow for easier migration to v2 WIP: Re-add static legacy API to allow for easier migration to v2 Aug 24, 2021
@felippeduran
Copy link
Member Author

@henriqueoelze and @gabrielcorado, I've added unit tests to all static methods to validate proper delegation to the non static API. Let me know if you need any other test cases to be included. I'll remove the WIP tag for now.

@felippeduran felippeduran changed the title WIP: Re-add static legacy API to allow for easier migration to v2 Re-add static legacy API to allow for easier migration to v2 Aug 25, 2021
luizmiranda7
luizmiranda7 approved these changes Aug 31, 2021
View reviewed changes
session/static.go Show resolved Hide resolved
@luizmiranda7 luizmiranda7 changed the base branch from v2 to main September 1, 2021 14:28
@luizmiranda7 luizmiranda7 merged commit fc4ba38 into main Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizmiranda7 luizmiranda7 luizmiranda7 approved these changes

@gabrielcorado gabrielcorado Awaiting requested review from gabrielcorado

@henriqueoelze henriqueoelze Awaiting requested review from henriqueoelze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@felippeduran @coveralls @luizmiranda7 @henriqueoelze