Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using GRPC, it's possible that we never connect to another server #94

Closed
felipejfc opened this issue Mar 19, 2019 · 0 comments
Closed
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@felipejfc
Copy link
Contributor

https://github.com/topfreegames/pitaya/blob/master/cluster/grpc_rpc_client.go#L234-L238

	conn, err := grpc.DialContext(ctxT, address, grpc.WithInsecure())
	if err != nil {
		logger.Log.Errorf("unable to connect to server %s at %s: %v", sv.ID, address, err)
		return
	}

This piece of code may lead us to having a known server that we never connect to, maybe we should remove the return and leave GRPC trying to reconnect and if the server is really messed up, eventually it will be removed and deleted from the local sd storage

@felipejfc felipejfc added enhancement New feature or request good first issue Good for newcomers labels Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant