Use protobuf only for RPC calls #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it possible to create cluster and RPC libs for other programming languages
Pull Request Test Coverage Report for Build 191
💛 - Coveralls |
cscatolini
reviewed
Jun 4, 2018
| @@ -91,7 +91,9 @@ func (a *Remote) Kick(ctx context.Context) error { | |||
| if a.Session.UID() == "" { | |||
| return constants.ErrNoUIDBind | |||
| } | |||
| b, err := util.GobEncode([]byte(a.Session.UID())) | |||
| b, err := proto.Marshal(&protos.KickMsg{ | |||
There was a problem hiding this comment.
can't we just byte encode the string like this: []byte(a.Session.UID())? or are you using a proto since you may wan't to send more data along with the ID?
There was a problem hiding this comment.
RPC must receive structs that implements proto.Message, a byte array doesn't
e2e/e2e_test.go
Outdated
| @@ -57,10 +57,10 @@ func TestHandlerCallToFront(t *testing.T) { | |||
| data []byte | |||
| resp []byte | |||
| }{ | |||
| {"connector.testsvc.testrequestonlysessionreturnsptr", []byte(``), []byte(`{"code":200,"msg":"hello"}`)}, | |||
| {"connector.testsvc.testrequestonlysessionreturnsptr", []byte(``), []byte(`{"Code":200,"Msg":"hello"}`)}, | |||
There was a problem hiding this comment.
we should keep our json keys as camel case
There was a problem hiding this comment.
this is because of protobuf, more details below
| @@ -50,8 +50,7 @@ func configureBackend() { | |||
|
|
|||
| func configureFrontend(port int) { | |||
| configureJaeger("connector") | |||
| ws := acceptor.NewWSAcceptor(fmt.Sprintf(":%d", port)) | |||
| tcp := acceptor.NewTCPAcceptor(fmt.Sprintf(":%d", port+1)) | |||
| tcp := acceptor.NewTCPAcceptor(fmt.Sprintf(":%d", port)) | |||
There was a problem hiding this comment.
why did you remove ws support? we're no longer accepting it?
There was a problem hiding this comment.
we didn't, it's just that we are not using the ws acceptor for nothing in this example
protos/pitaya.proto
Outdated
| @@ -52,3 +52,16 @@ message Error { | |||
| string msg = 2; | |||
| map<string, string> metadata = 3; | |||
| } | |||
|
|
|||
| message KickMsg { | |||
| string UserID = 1; | |||
protos/pitaya.proto
Outdated
| } | ||
|
|
||
| message KickAnswer { | ||
| bool Kicked = 1; |
protos/pitaya.proto
Outdated
| } | ||
|
|
||
| message BindMsg { | ||
| string UID = 1; |
| "github.com/topfreegames/pitaya/constants" | ||
| "github.com/topfreegames/pitaya/route" | ||
| ) | ||
|
|
||
| // RPC calls a method in a different server | ||
| func RPC(ctx context.Context, routeStr string, reply interface{}, args ...interface{}) error { | ||
| return doSendRPC(ctx, "", routeStr, reply, args...) | ||
| func RPC(ctx context.Context, routeStr string, reply proto.Message, arg proto.Message) error { |
There was a problem hiding this comment.
we no longer accept RPC calls with several arguments?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it possible to have servers made in other programming languages to send and receive RPC calls to go servers.