Add gradient background direction #9

Merged
merged 1 commit into from Nov 10, 2012

Conversation

Projects
None yet
3 participants
@fordguo
Contributor

fordguo commented Sep 3, 2010

add gradient direct

@topfunky

This comment has been minimized.

Show comment
Hide comment
@topfunky

topfunky Sep 23, 2010

Owner

Looks good, but could I get a test and better spacing?

For example, %w(black grey,:top_bottom) makes little sense. Just use a regular array if you are going to mix spaces and commas (and strings and symbols).

You could add to test_line.rb or similar to make a graph with the new gradient syntax.

Owner

topfunky commented Sep 23, 2010

Looks good, but could I get a test and better spacing?

For example, %w(black grey,:top_bottom) makes little sense. Just use a regular array if you are going to mix spaces and commas (and strings and symbols).

You could add to test_line.rb or similar to make a graph with the new gradient syntax.

@fordguo

This comment has been minimized.

Show comment
Hide comment
@fordguo

fordguo Sep 25, 2010

Contributor

en,the array is better
I will add the test for gradient,thanks good tips.

Contributor

fordguo commented Sep 25, 2010

en,the array is better
I will add the test for gradient,thanks good tips.

@ghost ghost assigned donv Nov 10, 2012

donv added a commit that referenced this pull request Nov 10, 2012

Merge pull request #9 from fordguo/gradient
Add gradient background direction

@donv donv merged commit 0b85fe4 into topfunky:master Nov 10, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment