From 118ef9260cb67369050c3bf7672e9aed0046f7f4 Mon Sep 17 00:00:00 2001 From: Atharva Arya <55894364+atharva-2001@users.noreply.github.com> Date: Fri, 18 Aug 2023 05:07:35 +0530 Subject: [PATCH] fix: preserve Falsy values in assertion diff function (#789) --- src/syrupy/assertion.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/syrupy/assertion.py b/src/syrupy/assertion.py index 328afb47..58861cad 100644 --- a/src/syrupy/assertion.py +++ b/src/syrupy/assertion.py @@ -206,7 +206,11 @@ def get_assert_diff(self) -> List[str]: # Rotate to place exception with message at first line return lines[-1:] + lines[:-1] snapshot_data = assertion_result.recalled_data - serialized_data = assertion_result.asserted_data or "" + serialized_data = ( + assertion_result.asserted_data + if assertion_result.asserted_data is not None + else "" + ) diff: List[str] = [] if snapshot_data is None: diff.append( @@ -215,7 +219,8 @@ def get_assert_diff(self) -> List[str]: ) ) if not assertion_result.success: - diff.extend(self.extension.diff_lines(serialized_data, snapshot_data or "")) + snapshot_data = snapshot_data if snapshot_data is not None else "" + diff.extend(self.extension.diff_lines(serialized_data, snapshot_data)) return diff def __with_prop(self, prop_name: str, prop_value: Any) -> None: