Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Proper Support for A-Only SAR #1674
First, I want to apologize in case it was inappropriate to create this as a new issue instead of a comment to the similar-sounding issue #1547. Since my stock ROM version and fastboot command outputs are different than #1547, I thought it might help avoid confusion to make this a separate issue.
I tried creating a patched boot.img for my Moto G7 Play (XT1952-4, stock ROM version CHANNEL_PPY29.105-116_cid50_subsidy-DEFAULT_regulatory-DEFAULT_CFC) with Magisk Manager and, like @ctonton had happen in #1547, after flashing the patched boot.img and rebooting, Magisk Manager still says that Magisk is not installed.
I then downloaded canary-builds/app-debug.apk and used it to patch my boot.img again. After flashing the magisk_patched.img that the canary build produced and rebooting again, the canary build of Magisk Manager still says that Magisk is not installed.
I am attaching the following files to this comment:
Like @ctonton, I noticed that the patched image is approximately 17 MB in size while the original image is 32 MB in size. I am not sure whether that is a problem, but it seems like it could be indicative of one.
Please let me know if there is anything else I should try, or any additional information I can provide that might be helpful.
This is Android 9 (Pie) so, as far as I can tell, there is no global "allow apps from unknown sources" option under Settings -> Security.
Under Settings -> Apps & notifications -> Special app access, there is a per-app permission of "Install unknown apps". Previously I had not enabled this for Magisk Manager, so just now I enabled it, updated Magisk Manager to the latest version, and used it to again patch my boot.img.
The new magisk_patched.img file that was created has the same md5sum as my previous magisk_patched.img. I flashed this image onto the phone anyway with "fastboot flash boot magisk_patched.img" and received the same fastboot output as before. I then booted the phone and ran Magisk Manager but, as before, it still says that Magisk is not installed.
I looked at the magisk_install_log that was generated by Manager when patching the boot.img and its contents were substantially the same as before (although I am attaching them for the sake of thoroughness).
I'm confused why this device is considered 'A-only SaR'
Channel also appears to be an A/B device. The firmware's info.txt says "AB Update Enabled: True" and there are system and oem images that flash to slot _b
Seems more like an issue with zImage as @13-beta2 said, which will not be fixed
See the Motorola G7 (river) is 64bit a/b device
After rebuilding the stock kernel stand-alone or inline the device bootloops with magisk installed
I believe its also zimage generation related so maybe there should be a patch/hack or some sort of documentation for generating magisk compatible zimage