"Hide the Magisk App" fails without "Install Unknown Apps" permission

[huw0]

"Hide the Magisk App" fails if Magisk Manager does not have permission to "Install Unknown Apps". There is no prompt that this functionality is missing. Instead the hidden app is in a half-installed state where there is a launcher icon but it cannot be launched.

Magisk Manager should check that it has this permission before attempting to hide.

This permission prompt for this successfully appears when updating (or reinstalling) Magisk Manager from within Magisk Manager. After this the "Hide the Magisk App" function works successfully.

Device: Pixel 5
Android version: 11
Magisk version name: 23014
Magisk version code: 23014

[vvb2060]

@osm0sis Can you reproduce it?

[osm0sis]

On MIUI I definitely can

[vvb2060]

@osm0sis

video_2021-11-24_22-35-06.mp4

[Howard20181]

@osm0sis

video_2021-11-24_22-35-06.mp4

MIUI 12.5 21.11.23 Nightly
Android 11

[vvb2060]

video_2021-11-24_22-36-37.mp4

Pixel5 RQ3A.211001.001

[osm0sis]

I'll add my Poco X2 video here later, since we're doing show-and-tell. 😛

[huw0]

Probably should've mentioned in the original summary - this is with the latest LineageOS, rather than stock AOSP.
I note one of the videos shows a USB install popup - if it makes a difference I have ADB debug disabled.

[vvb2060]

No one can reproduce it or provide a valid log.

[osm0sis]

I can reproduce the issue, repeatedly, with ease.
logcat.log

I can give you logs, but wouldn't be able to fix it myself.

I have a screen recording of the whole process but it's 100mb. I'll upload it to my AFH if you want to inspect it.
https://androidfilehost.com/?fid=7161016148664847413

[vvb2060]

ActivityManager: Killing 9793:com.topjohnwu.magisk/u0a166 (adj 700): REQUEST_INSTALL_PACKAGES changed.

Granting REQUEST_INSTALL_PACKAGES kills the process and when returning to the app it is already a new process, causing the previously registered install broadcast receiverto be lost.

Magisk/app/src/main/java/com/topjohnwu/magisk/core/tasks/HideAPK.kt

Lines 143 to 146 in 1c8ebfa

	// Install and auto launch app
	APKInstall.registerInstallReceiver(activity, WaitPackageReceiver(pkg, activity))
	if (!Shell.su("adb_pm_install $repack").exec().isSuccess)
	APKInstall.installHideResult(activity, repack)

[osm0sis]

Added video above. 👍