From dedee96dd62110895b8cae7eedfaefcd82bbf42a Mon Sep 17 00:00:00 2001 From: Yuji Ito Date: Tue, 28 Nov 2023 07:56:00 +0000 Subject: [PATCH 1/2] docs: add note about loading lvmd config file Signed-off-by: Yuji Ito --- docs/lvmd.md | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/docs/lvmd.md b/docs/lvmd.md index 6e05dd3b2..c8d76474e 100644 --- a/docs/lvmd.md +++ b/docs/lvmd.md @@ -46,15 +46,15 @@ device-classes: The device-class settings can be specified in the following fields: -| Name | Type | Default | Description | -| ------------------- | ------ | ------- | ---------------------------------------------------------------------------------- | -| `name` | string | - | The name of a device-class. | -| `volume-group` | string | - | The group where this device-class creates the logical volumes. | -| `spare-gb` | uint64 | `10` | Storage capacity in GiB to be spared. | -| `default` | bool | `false` | A flag to indicate that this device-class is used by default. | -| `stripe` | uint | - | The number of stripes in the logical volume. | -| `stripe-size` | string | - | The amount of data that is written to one device before moving to the next device. | -| `lvcreate-options` | []string | - | Extra arguments to pass to `lvcreate`, e.g. `["--type=raid1"]`. | +| Name | Type | Default | Description | +| ------------------ | -------- | ------- | ---------------------------------------------------------------------------------- | +| `name` | string | - | The name of a device-class. | +| `volume-group` | string | - | The group where this device-class creates the logical volumes. | +| `spare-gb` | uint64 | `10` | Storage capacity in GiB to be spared. | +| `default` | bool | `false` | A flag to indicate that this device-class is used by default. | +| `stripe` | uint | - | The number of stripes in the logical volume. | +| `stripe-size` | string | - | The amount of data that is written to one device before moving to the next device. | +| `lvcreate-options` | []string | - | Extra arguments to pass to `lvcreate`, e.g. `["--type=raid1"]`. | Note that striping can be configured both using the dedicated options (`stripe` and `stripe-size`) and `lvcreate-options`. Either one can be used but not together since this would lead to duplicate arguments to `lvcreate`. @@ -65,6 +65,8 @@ stripe: 2 lvcreate-options: ["--mirrors=1"] ``` +After updating the configuration file, you need to restart lvmd. If you are running lvmd as a DaemonSet, restart the Pods after updating the ConfigMap. If you want to restart automatically, consider using [Reloader](https://github.com/stakater/Reloader) or similar. + Spare capacity -------------- From eddaecfb2806d5f2316510c4c70b4a1a92488514 Mon Sep 17 00:00:00 2001 From: Yuji Ito Date: Tue, 28 Nov 2023 18:20:28 +0900 Subject: [PATCH 2/2] Update docs/lvmd.md Signed-off-by: Yuji Ito Co-authored-by: Satoru Takeuchi --- docs/lvmd.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/lvmd.md b/docs/lvmd.md index c8d76474e..23637fb88 100644 --- a/docs/lvmd.md +++ b/docs/lvmd.md @@ -65,7 +65,7 @@ stripe: 2 lvcreate-options: ["--mirrors=1"] ``` -After updating the configuration file, you need to restart lvmd. If you are running lvmd as a DaemonSet, restart the Pods after updating the ConfigMap. If you want to restart automatically, consider using [Reloader](https://github.com/stakater/Reloader) or similar. +After changing the configuration file, you need to restart lvmd to reflect this change. If lvmd is deployed as a DaemonSet, pod restart is needed after changing the corresponding ConfigMap. If you want to restart lvmd automatically after changing configuration, please use 3rd party tools like [Reloader](https://github.com/stakater/Reloader). Spare capacity --------------