Provides a smart way to determine the number 'top' lines

[minchinweb]

Looks at the prompt or PS1 environmental variables to determine the number of
newlines contained in them.

I've tested in on my end in Windows, and it works as expected. I don't have Linux or Mac box, so I haven't been able to test it there.

Because of the way it works (by counting newlines), it won't work exactly right if the prompt goes over the line end without a line break (i.e. for a really long path) or if there are conditional linebreaks in the PS1 variable.

Tests have been added and updated as well.

Fixes #102.

[codecov-io]

Current coverage is 87.48%

Merging #118 into master will decrease coverage by 9.98%

1. 5 files (not in diff) in topydo/cli were created. more
2. 1 files (not in diff) in topydo were created. more
3. 2 files in topydo/lib were modified. more
   • Hits +7
4. 1 files in topydo were modified. more
5. 9 files (not in diff) in topydo/lib were modified. more
   • Misses -3
   • Partials -2
   • Hits -55
6. 6 files (not in diff) in topydo/commands were modified. more
   • Partials +2
   • Hits +9
7. 4 files (not in diff) in topydo/lib were deleted. more

@@             master    #118   diff @@
=======================================
  Files            50      52     +2   
  Lines          2562    2724   +162   
  Methods           0       0          
  Branches        406     415     +9   
=======================================
- Hits           2497    2383   -114   
- Misses           38     315   +277   
+ Partials         27      26     -1   

Powered by Codecov. Last updated by 14ab34d...b1e47ed

[bram85]

Change looks OK. Can you make sure to clean up the history such that Colors.py is not in the diff anymore? Then it looks OK to merge.

[minchinweb]

@bram85 : Colours.py "fixed"

[bram85]

@minchinweb I had another look at your code, and I was wondering why you implemented _N_lines in the ListFormat.py module instead of ListCommand.py. The latter is the only client and I don't see much coherence with the formatting functionality (i.e. replacing placeholders). Did you do this for a particular reason? If not, I'd prefer to see this calculation in ListCommand.py.

[minchinweb]

@bram85 : the _N_lines function was placed were it was because that seemed to match (my limited understanding of) the organization used in the project. But no worries, I've moved it as you've suggested.