Conversation
Current coverage is 97.31% (diff: 94.11%)@@ master #131 diff @@
==========================================
Files 50 50
Lines 2589 2605 +16
Methods 0 0
Messages 0 0
Branches 410 415 +5
==========================================
+ Hits 2518 2535 +17
+ Misses 43 41 -2
- Partials 28 29 +1
|
topydo/lib/Filter.py
Outdated
| """ | ||
| Constructor. | ||
|
|
||
| A filter which selects a number of Todo instances from a TodoList |
Member
There was a problem hiding this comment.
The documentation matches the preceding filter.
Contributor
Author
|
@bram85 : Fixes added! |
Use the `h:1` tag to hide items from being listed
Contributor
Author
|
Rebased to v0.10 release |
topydo/lib/Filter.py
Outdated
| A filter which hides items marked with the approriate tag. | ||
| """ | ||
| super().__init__() | ||
| self.todos = p_todos |
Member
There was a problem hiding this comment.
self.todos is not used, so I'd remove it from the constructor.
Member
|
Looks good as far as I can see, bar a minor remark on an unused variable. Personally I use the |
Contributor
Author
|
@bram85 : I've removed the unused variable. I think we're good to go then! |
Member
|
Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the
h:1tag to hide items from being listedIncludes tests (existing tests were adjusted to test for the expected behavior)