Style Changes #55
Merged
Style Changes #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll sort alphabetically
This allows the default discover on unittest to work
continuation line with same indent as next logical line
continuation line over-indented for visual indent
continuation line under-indented for visual indent
whitespace after '('
whitespace before ')'
whitespace before ':'
multiple spaces before operator
missing whitespace around operator
missing whitespace after ':' missing whitespace after ','
at least two spaces before inline comment
trailing whitespace
blank line contains whitespace
expected 1 blank line, found 0
expected 2 blank lines, found 1 (above module level defined classes and functions)
too many blank lines
blank line at end of file
line too long (> 79 characters)
the backslash is redundant between brackets
statement ends with a semicolon
comparison to None should be 'if cond is None:' or 'if cond is not None:'
Sorted using `isort`. Sorted alphabetically, with sections for standard library, third-party, and then internal imports.
Allows monitoring to see how close we are to supporting these on these platforms.
|
Thanks for your patch. Had a quick look at it, seems to look good overall. I'll be out of town for a couple of days, will review it more thoroughly somewhere next week. |
1 blank line required after class docstring
No blank lines allowed after function docstring
First line should end with a period
|
Sounds great |
| self.assertEqual(self.errors, "") | ||
|
|
||
| def test_add_dep4(self): | ||
| def test_add_de04(self): |
|
Looks great, will merge it despite the minor typo. Thanks a lot for your effort to fix those style issues. |
mruwek
added a commit
to mruwek/topydo
that referenced
this issue
Oct 13, 2015
Adhere to standards introduced with topydo#55
mruwek
added a commit
to mruwek/topydo
that referenced
this issue
Oct 13, 2015
Adhere to standards introduced with topydo#55
mruwek
added a commit
to mruwek/topydo
that referenced
this issue
Oct 13, 2015
Adhere to standards introduced with topydo#55
MinchinWeb
added a commit
to MinchinWeb/topydo
that referenced
this issue
Oct 14, 2015
See pull request topydo#55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is all the style changes split out of PR #52.
There should be no substantial code changes, just style fixes.
Issues addressed:
topydois to running on those platformsunittest's default auto-discovery to work