New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add potrs with MAGMA #364

Merged
merged 1 commit into from Mar 22, 2016

Conversation

Projects
None yet
3 participants
@bamos
Contributor

bamos commented Mar 13, 2016

Hi, this PR adds potrs with MAGMA.

I followed the structure of the existing potrf code and copied the
potrs argument checks from THTensorLapack.
The test compares the output to Torch's CPU version and is passing on my system.

This is my first time modifying cutorch and any Torch internals.
Can somebody check that I used THCudaTensor_newColumnMajor and free correctly?
I used rb_ as the source for b_ because magma_spotrs_gpu returns results in b_data.
I'm not sure if I should use th_magma_smalloc_pinned or THCudaTensor_newColumnMajor for a_data.

-Brandon.

Show outdated Hide outdated lib/THC/THCTensorMathMagma.cu Outdated
@colesbury

This comment has been minimized.

Show comment
Hide comment
@colesbury

colesbury Mar 21, 2016

Contributor

See in-line comment, but otherwise LGTM. Thanks for adding this!

Contributor

colesbury commented Mar 21, 2016

See in-line comment, but otherwise LGTM. Thanks for adding this!

@bamos

This comment has been minimized.

Show comment
Hide comment
@bamos

bamos Mar 22, 2016

Contributor

Hi @colesbury - thanks! I've fixed freeing b_ and have squashed my commits.

-Brandon.

Contributor

bamos commented Mar 22, 2016

Hi @colesbury - thanks! I've fixed freeing b_ and have squashed my commits.

-Brandon.

soumith added a commit that referenced this pull request Mar 22, 2016

@soumith soumith merged commit 40d3f52 into torch:master Mar 22, 2016

@soumith

This comment has been minimized.

Show comment
Hide comment
@soumith

soumith Mar 22, 2016

Member

Thanks Brandon!

Member

soumith commented Mar 22, 2016

Thanks Brandon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment