New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install.sh `luarocks path -bin` typo #56

Merged
merged 1 commit into from Dec 7, 2015

Conversation

Projects
None yet
2 participants
@lucasb-eyer
Contributor

lucasb-eyer commented Dec 7, 2015

-bin doesn't exist, it's --bin. But since apparently nobody ever complained, I guess it's not needed because all binaries are run using full path.
Although since it doesn't seem to be needed you might rather want to remove it entirely?

PS: Using LuaRocks 2.2.0beta1.

Fix install.sh `luarocks path -bin` typo
Since apparently nobody ever complained, I guess it's not needed because all binaries are run using full path. `-bin` doesn't exist, it's `--bin`.
But since it doesn't seem to be needed, you might rather want to remove it entirely?

soumith added a commit that referenced this pull request Dec 7, 2015

Merge pull request #56 from lucasb-eyer/patch-2
Fix install.sh `luarocks path -bin` typo

@soumith soumith merged commit 5c9b74a into torch:master Dec 7, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lucasb-eyer

This comment has been minimized.

Show comment
Hide comment
@lucasb-eyer

lucasb-eyer Dec 7, 2015

Contributor

I just noticed that fixing this command will actually generate a duplicate PATH entry in torch-activate here.

Contributor

lucasb-eyer commented Dec 7, 2015

I just noticed that fixing this command will actually generate a duplicate PATH entry in torch-activate here.

@soumith

This comment has been minimized.

Show comment
Hide comment
@soumith

soumith Dec 7, 2015

Member

hehe thanks. funny that no one ever noticed

Member

soumith commented Dec 7, 2015

hehe thanks. funny that no one ever noticed

1 similar comment
@soumith

This comment has been minimized.

Show comment
Hide comment
@soumith

soumith Dec 7, 2015

Member

hehe thanks. funny that no one ever noticed

Member

soumith commented Dec 7, 2015

hehe thanks. funny that no one ever noticed

@lucasb-eyer lucasb-eyer deleted the lucasb-eyer:patch-2 branch Dec 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment