Permalink
Browse files

removing sys dependency for now

  • Loading branch information...
1 parent f7ff82d commit c6554c0c394d50a74e63bb106343c9f36ddfd41a @soumith soumith committed Mar 9, 2016
Showing with 1 addition and 2 deletions.
  1. +1 −2 rocks/torch-scm-1.rockspec
@@ -16,8 +16,7 @@ description = {
dependencies = {
"lua >= 5.1",
"paths >= 1.0",
- "cwrap >= 1.0",
- "sys >= 1.0"
+ "cwrap >= 1.0"
}
build = {

3 comments on commit c6554c0

@hughperkins
Contributor

Ah, interesting. I was just about to ask why we install sys after installing torch, in distro/install.sh :-) Do you mind if I ask:

  • why was sys a dependency before?
  • why can we remove it now?
  • implications of removing it?

(Since I'm using torhc as of ~17th Februrary, and it still has a sys dependency)

@fmassa
Contributor
fmassa commented on c6554c0 Sep 17, 2016

@hughperkins I think this has to do with some deadlock that what happening in some systems. I this this is related to torch/image#157

@hughperkins
Contributor

that explains removing it. as far as why it was there, just this moment found that the old Tester.lua uses it :-)

tester_sys

Please sign in to comment.