New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress show total time when done. (vs ETA: 0ms) #13

Merged
merged 1 commit into from Dec 9, 2015

Conversation

Projects
None yet
3 participants
@lucasb-eyer
Contributor

lucasb-eyer commented Dec 9, 2015

I think that it's more useful than ETA: 0ms and it's more precise than doing step * N in my head, especially if step varies.

soumith added a commit that referenced this pull request Dec 9, 2015

Merge pull request #13 from lucasb-eyer/master
Progress show total time when done. (vs ETA: 0ms)

@soumith soumith merged commit be54d0c into torch:master Dec 9, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@soumith

This comment has been minimized.

Show comment
Hide comment
@soumith

soumith Dec 9, 2015

Member

pretty useful indeed. thanks a lot.

Member

soumith commented Dec 9, 2015

pretty useful indeed. thanks a lot.

@jnhwkim

This comment has been minimized.

Show comment
Hide comment
@jnhwkim

jnhwkim Feb 27, 2016

Contributor

It ruins the center align of progress indicator (e.g. 92/100). Because tm is removed though it is used in https://github.com/torch/xlua/blob/master/init.lua#L293. I'll send a pull request to fix. p.s. #15

Contributor

jnhwkim commented on a37ffac Feb 27, 2016

It ruins the center align of progress indicator (e.g. 92/100). Because tm is removed though it is used in https://github.com/torch/xlua/blob/master/init.lua#L293. I'll send a pull request to fix. p.s. #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment