Skip to content

Conversation

@jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Jul 5, 2020

Description

Please include a summary of the changes and which issue this relates to (if applicable). Please list any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@thibaudcolas
Copy link
Member

Hey @jayvdb, thank you for giving this a shot but apparently Poetry doesn’t work like this. From CI:

[RuntimeError]
The Poetry configuration is invalid:
  - Additional properties are not allowed ('url' was unexpected)

Apparently the key is called homepage for Poetry: https://python-poetry.org/docs/pyproject/#homepage. I assume that’s what you were after (please take the time to write a description for the PR next time?), so will edit the WIP PR accordingly.

@thibaudcolas thibaudcolas added the enhancement New feature or request label Jul 27, 2020
@thibaudcolas thibaudcolas added this to the Nice to have milestone Jul 27, 2020
@thibaudcolas thibaudcolas changed the title pyproject.toml: Add url pyproject.toml: Add homepage url Jul 27, 2020
@thibaudcolas thibaudcolas merged commit abd81b1 into torchbox:master Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

2 participants