Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add revisions button to page list #2410

Closed
wants to merge 1 commit into from
Closed

Add revisions button to page list #2410

wants to merge 1 commit into from

Conversation

jaroel
Copy link
Contributor

@jaroel jaroel commented Mar 29, 2016

This skips editing the page to get to the revisions.

This skips editing the page to get to the revisions.
@SalahAdDin
Copy link
Contributor

👍

@alexgleason
Copy link
Contributor

Hi @jaroel, thank you for the contribution! Could you please provide a screenshot? Thanks. 😄

@jaroel
Copy link
Contributor Author

jaroel commented Mar 30, 2016

It's the last button called 'Revisies'
screen shot 2016-03-30 at 20 01 43

@gasman
Copy link
Collaborator

gasman commented Mar 31, 2016

Hi @jaroel,

This pull request needs to be recreated against master, rather than the stable/1.4.x branch - 1.4.x is only receiving bug fixes from now on, and the button code has changed in 1.5 / master (#1940).

We've previously considered and rejected the idea of having 'revisions' in the explorer actions, in #640 - the list of buttons was too long already, and 'revisions' doesn't really work as an action verb in the same way as 'edit', 'move', 'delete' etc (see #640 (comment)). I think those concerns still stand (although at least in 1.5 the 'More...' dropdown means the length of the list isn't as much of a problem) - but I'll leave this open for discussion in case other devs have different thoughts.

@davecranwell
Copy link
Contributor

I think the "More..." dropdown resolves the concerns I had on #640.

As things stand, with the limited space available for buttons its important to ensure only the most important buttons are given priority. The more buttons you add, the more they jostle for attention. Revisions would not be considered a priority button in that context and to my mind would be a distraction.

However with a "More" dropdown, the problem of distraction is solved. Thus the problem of consistent messages ("verbs") is also less pronounced since it takes less time to mentally process the UI if fewer buttons are visible in the first place. I would however expect Revisions to be a "More" action, certainly not a primary one, for the reasons I've stated before (switching a revision is an action tightly coupled with editing the page, so is best done from the vantage point of the page editor.)

I might suggest this is merged only after the More button is.

@gasman
Copy link
Collaborator

gasman commented Mar 31, 2016

The More button is already in master, so it sounds like this is PR ready to be re-applied on master too.

@jaroel
Copy link
Contributor Author

jaroel commented Mar 31, 2016

I'll make a new PR on master and place it under 'More'.

@jaroel jaroel closed this Apr 4, 2016
@jaroel jaroel deleted the page-list-revisions-button branch April 4, 2016 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants