Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RV4FL mesh data #11

Merged
merged 6 commits into from Nov 19, 2018

Conversation

Projects
None yet
2 participants
@KazukiHiraizumi
Copy link
Collaborator

commented Nov 11, 2018

Meshは”RV4FL"のものですので、ご注意ください。
Step形式(.stp)も置いていますので、3DCADで編集可能と思います。
equipment/にはYOODSのカメラ(+エアピッカー)のデータも置いています。
こちらはご参考まで

@7675t

This comment has been minimized.

Copy link
Member

commented Nov 12, 2018

ありがとうございます. @KazukiHiraizumi
提供していただいたRV4FLのデータを元に,RV7FLのデータも作成しました.

一般的にPull Requestを送るときには,masterブランチではなく新たなブランチを作ってそこからPull Requestをした方が良いです.Github Flowと呼ばれます.

@7675t

This comment has been minimized.

Copy link
Member

commented Nov 12, 2018

提供いただいたもののライセンスについて,

  • ソースコード(RV4FLのURDFを含む)については,Apache2.0
  • メッシュファイルは,CC-BY-SA

と,とりあえず設定しましたが,これでOKでしょうか? @KazukiHiraizumi
ご希望があればお願いします.

KazukiHiraizumi and others added some commits Nov 11, 2018

Modify URDF to adopt the package structure
- Add robot argument to specify target robot
Add mesh files for RV7FL
- They are modified its origin, rotation in mesh
- Scale are modified in URDF

@7675t 7675t force-pushed the master branch from 9c77065 to de40a93 Nov 12, 2018

@7675t

This comment has been minimized.

Copy link
Member

commented Nov 16, 2018

@KazukiHiraizumi 様、
公開時のライセンスの件、ご確認いただけますでしょうか。OKであればマージします。
お忙しいところ恐縮ですがよろしくお願いします。

@7675t

This comment has been minimized.

Copy link
Member

commented Nov 19, 2018

Thank you! @KazukiHiraizumi

@7675t 7675t merged commit 1a14de7 into tork-a:master Nov 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

7675t added a commit that referenced this pull request Nov 19, 2018

7675t added a commit that referenced this pull request Nov 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.