Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Migrate common portion up to rtmros_hironx #58

Closed
130s opened this Issue · 3 comments

2 participants

@130s
Owner

rtmros_nextage depends on rtmros_hironx. There are doubled work in rtmros_nextage that can be ported up to rtmros_hironx package. so that we can reduce maintainance work.

I can think of:

  • nextage_ros_bridge/script.
  • nextage_ros_bridge/test except tests for hands.

Unique to rtmros_nextage:

  • python code for hands nextage_ros_bridge/src/nextage_ros_bridge/*hand*.py files and command folder.
  • models (maybe the entire nextage_description package).
@130s 130s added the enhancement label
@130s
Owner

models (maybe the entire nextage_description package).

Model is specific to NXO so we don't want to consolidate model files into upstream package. Instead, do so to nextage_description pkg. #68

nextage_ros_bridge/script.

I don't see any reason why we don't do this, other than users have to change the name of the file they run, like this:

NOW: ipython -i `rospack find nextage_ros_bridge`/script/nextage.py
NEW: ipython -i `rospack find hironx_ros_bridge`/script/operate_robot.py
@k-okada
Owner
@130s
Owner

another view point is it is confusing to using hironx_ros_bridge file for nextage, so we'll keep nextage.py ( or other name ) file under nextage_ros_bridge/script but that file is just load file under hironx_ros_bridge.

+1

Meanwhile, I hold back what I said:

I don't see any reason why we don't do this, other than users have to change the name of the file they run, like this:

NOW: ipython -i `rospack find nextage_ros_bridge`/script/nextage.py
NEW: ipython -i `rospack find hironx_ros_bridge`/script/operate_robot.py

In the current design, hand commands are also called from NextageClient. So it would be simpler for us for now to keep scripts separately.

@130s 130s closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.