Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DIO pin checker #94

Closed
130s opened this issue Jul 23, 2014 · 4 comments

Comments

Projects
None yet
2 participants
@130s
Copy link
Contributor

commented Jul 23, 2014

From #93

TODOs:

  • Add tests for checking if digital IO work accordingly as in the spec.
  • Dismiss these tests on CI tools (jenkins, travis etc.) Because all the tests added in PReq require hardware, these tests become ERROR.

@130s 130s added the enhancement label Jul 23, 2014

@k-okada

This comment has been minimized.

Copy link
Member

commented Jul 24, 2014

Dismiss these tests on CI tools

IO related code should run on simulation, although readIO just returns writeIO data. Please let me know if you create test code for DIO.

@130s

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2014

Ah I've added them...Is there a way to bypass them on CI tests?

@k-okada

This comment has been minimized.

Copy link
Member

commented Jul 24, 2014

Created patch fkanehiro/hrpsys-base#273, that just ignore read/write dio on simulation mode, once this patch has accepted, CI error will gone

@130s

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2014

Thank you for fkanehiro/hrpsys-base#273 that seems to be working for travis build. *handlight* methods still need to be taken care of. They are in NXO level (not in hrpsys). I'll work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.