tornado.platform.twisted disappeared but did not explain its replacement

[glyph]

Many years' worth of documentation explains that folks can do

from tornado.platform.twisted import install
reactor = install()

I can see that in 004de9c#diff-77b5a8a33248ef0bcafbc1bb71e9f013 Twisted integration was removed, since we can all depend on the stdlib loop APIs. This is great, but it also breaks a bunch of Jupyter notebooks, tutorials, etc.

Could you be convinced to replace all those sprawling APIs with something like this:

def install():
    from twisted.internet.asyncioreactor import install
    install()
    from twisted.internet import reactor
    reactor.startRunning()
    return reactor

possibly with a warnings.warn explaining that users could just call these APIs directly, if that's the desired end-state?

[bdarnell]

To be honest I didn't realize anyone but me ever used this module, until your message to async-sig a few days ago :) I can't remember the last time anyone asked any questions about it, so I assumed that indicated a lack of interest.

I also thought that install() had stopped working on python 3 in Tornado 5.0 (without anyone complaining) so it was safe to remove the python 2-only functionality in Tornado 6 (this is why I failed to add deprecation warnings in addition to the doc comments). But now that I think about it some more, this was wrong. TwistedIOLoop was no longer usable in Tornado 5+Python 3, but TornadoReactor and install() would (I think) still work.

If there's demand for it, I think I'm fine with keeping tornado.platform.twisted.install around indefinitely using asyncioreactor instead of TornadoReactor.

[glyph]

Thanks @bdarnell ! That would definitely work for me.

[glyph]

Thanks a ton for doing this!