Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Setting no_keep_alive option on HTTPServer does not set "Connection: close" header #641

Closed
swisspol opened this Issue Nov 22, 2012 · 1 comment

Comments

Projects
None yet
2 participants

According to the specs http://tools.ietf.org/html/rfc2616#section-8.1:

HTTP/1.1 applications that do not support persistent connections MUST include the "close" connection option in every message.

So the way I read this: if configuring HTTPServer with no_keep_alive, it doesn't support persistent connections by definition and must set the "Connection: close" header.

Owner

bdarnell commented Nov 26, 2012

I think you're right about the requirement (although it's a SHOULD rather than a MUST). However, HTTPServer doesn't participate in the response header generation so it cannot add the "Connection: close" header itself. Maybe this means that the no_keep_alive option to HTTPServer should not be used, and instead it's up to the Application (or equivalent) to set "Connection: close" as needed.

@bdarnell bdarnell closed this in e25b753 Dec 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment