Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Better error message for fetch() on closed AsyncHTTPClient #866

Closed
bdarnell opened this Issue Aug 4, 2013 · 0 comments

Comments

Projects
None yet
1 participant
Owner

bdarnell commented Aug 4, 2013

Calling fetch() on a closed AsyncHTTPClient raises a confusing error message (AttributeError on NoneType). This is made doubly confusing by the magic instance-sharing (in which case the close probably happened on what looks like a completely different instance). This should raise a more explicit error and the docs should be updated to explicitly discourage the use of AsyncHTTPClient.close.

Discussion: https://groups.google.com/forum/#!searchin/python-tornado/asynchttpclient$20only$20first$20request$20works/python-tornado/42r2Cxv90Aw/N_8LXTIzKXIJ

@bdarnell bdarnell closed this in c1ba948 Jun 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment