fix Content-Type for gzip in StaticFileHandler #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, but can you add a test for it? You can add some small files with |
|
OK, I'll create a new PR with both the test and the fixes. |
|
You don't have to close this PR; you can just push a new commit to the branch. It's usually better to re-use an existing PR to keep all the discussion about a change in one place. |
|
Oh, OK. Reopening and pushing new changes. |
|
Some of the test failures aren't your fault; rebase or merge to get fixes for the twisted/asyncio stuff. You also need to replace a set literal in the test for python 2.6 compatibility. |
The python mimetypes module used by StaticFileHandler will recognize compression (gzip, bz2, etc.) as the file encoding, and will give the mime type for the uncompressed file. This commit will fix this behavior, so a gzip file will end up as application/gzip. Additionally, unknown file types (or known file types compressed with anything other than gzip) are served as application/octet-stream.
|
OK, rebased and fixed. |
bdarnell
added a commit
that referenced
this pull request
Jul 31, 2015
fix Content-Type for gzip in StaticFileHandler
zakandrewking
added a commit
to SBRG/bigg_models
that referenced
this pull request
Aug 5, 2015
Checked encoding for compressed files, and serves the correct content type. This is based on the pull request by @aebrahim here: tornadoweb/tornado#1468
zakandrewking
added a commit
to SBRG/bigg_models
that referenced
this pull request
Aug 5, 2015
Checked encoding for compressed files, and serves the correct content type. This is based on the pull request by @aebrahim here: tornadoweb/tornado#1468
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python mimetypes module only recognizes gzip as the encoding. This will
detect a gzip encoding from mimetypes and make sure the Content-Type
ends up as application/gzip
This replaces #1465.