CurlAsyncHTTPClient: free_list starvation if setup fails #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `_curl_setup_request` fails, the failing curl instance would be permanently excluded from free_list, because `_finish` will never be called. Once this has happens `max_clients` times, no future request will ever complete.
|
LGTM. Would you like to add a test in curl_httpclient_test.py that creates a |
minrk
force-pushed
the
free-list-on-fail
branch
from
69dc8c8
to
699be78
Compare
|
Test added. |
|
Nicely factored, thanks! But the unicode trick isn't causing the error you expect in Python 2. |
minrk
force-pushed
the
free-list-on-fail
branch
from
699be78
to
4bec60e
Compare
ensure that it doesn't starve free curl client list
minrk
force-pushed
the
free-list-on-fail
branch
from
4bec60e
to
aabad7a
Compare
|
Removed the typecheck on the error, since it doesn't actually matter. The important thing is that failure of some sort doesn't cause it to hang. |
|
@bdarnell I think we should merge this. |
bdarnell
added a commit
that referenced
this pull request
Nov 12, 2015
CurlAsyncHTTPClient: free_list starvation if setup fails
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
_curl_setup_requestfails, the failing curl instance would be permanently excluded from free_list, because_finishwill never be called. Once this has happensmax_clientstimes, no future request will ever complete.This can be seen by requesting a non-ascii URL
max_clients + 1times.