Move 'cookies' property from RequestHandler to HTTPRequest #336

merged 1 commit into from Aug 28, 2011


None yet
3 participants

alekstorm commented Aug 18, 2011

The cookies property seems to belong more properly to HTTPRequest, since it's derived from the request headers. This also exposes it as a useful API to programs which don't subclass Application, relying solely on the httpserver module.

Tests are also updated.


jehiah commented Aug 28, 2011

this pull request should probably still expose a proxy parameter on RequestHandler so that it's backwards compatible with anything that is using that currently

@bdarnell bdarnell merged commit 4a4d871 into tornadoweb:master Aug 28, 2011


bdarnell commented Aug 28, 2011

jehiah++. Merged with the RequestHandler.cookies property added back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment