Added support for HTTP/1.1 100 Continue response #446

Closed
wants to merge 3 commits into from

2 participants

@yyuu

Added support for HTTP/1.1 100 Continue response in tornado.simple_httpclient.

Some servers such like Amazon S3 will return it if "Expect: 100-Continue" is in request header.

@yyuu

sorry, i added missing test case for my change.

yyuu@c0fe2e5

should I close this pull request and then reopen?

@bdarnell
tornadoweb member

What good does it do to send "Expect: 100-continue" in this way? The purpose of 100-continue is to let clients know whether an upload will succeed before they send the request body, so it seems to me that a meaningful implementation of client-side 100-continue support would have to occur in between sending the request headers and body.

@yyuu

Thanks for response.

As you say, just skipping 100-continue response during response body processing is not enough meaningful for the purpose. I fixed the impl to handle 100-continue response before sending request body.
Could you please check again?

@bdarnell
tornadoweb member

I apologize for letting this pull request slip through the cracks. Client-side 100-continue support has just landed in the master branch.

@bdarnell bdarnell closed this Apr 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment