Don't set SO_REUSEADDR on Windows #551

Merged
merged 2 commits into from Jun 29, 2012

Projects

None yet

3 participants

@minrk
Contributor
minrk commented Jun 28, 2012

Windows interprets REUSEADDR differently, allowing simultaneous instances.

EDIT: SO_EXCLUSIVEADDR is an alternative, but it seems like doing nothing is actually the best choice.

closes #550

@alekstorm
Contributor

Checking sys.platform == 'win32' excludes some Windows versions. Try os.name == 'nt' instead.

@minrk
Contributor
minrk commented Jun 28, 2012

done.

@bdarnell bdarnell merged commit cfd7a96 into tornadoweb:master Jun 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment