Don't set SO_REUSEADDR on Windows #551

Merged
merged 2 commits into from Jun 29, 2012

Conversation

Projects
None yet
3 participants
@minrk
Contributor

minrk commented Jun 28, 2012

Windows interprets REUSEADDR differently, allowing simultaneous instances.

EDIT: SO_EXCLUSIVEADDR is an alternative, but it seems like doing nothing is actually the best choice.

closes #550

@alekstorm

This comment has been minimized.

Show comment Hide comment
@alekstorm

alekstorm Jun 28, 2012

Contributor

Checking sys.platform == 'win32' excludes some Windows versions. Try os.name == 'nt' instead.

Contributor

alekstorm commented Jun 28, 2012

Checking sys.platform == 'win32' excludes some Windows versions. Try os.name == 'nt' instead.

@minrk

This comment has been minimized.

Show comment Hide comment
@minrk

minrk Jun 28, 2012

Contributor

done.

Contributor

minrk commented Jun 28, 2012

done.

bdarnell added a commit that referenced this pull request Jun 29, 2012

Merge pull request #551 from minrk/reuseaddr
Don't set SO_REUSEADDR on Windows

@bdarnell bdarnell merged commit cfd7a96 into tornadoweb:master Jun 29, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment