Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Use time.monotonic() where available. #583
apenwarr wants to merge 2 commits into tornadoweb:masterfrom apenwarr:monotime
Commits on Aug 14, 2012
Aug 14, 2012
Twisted 10.0 (on an older version of Ubuntu) doesn't seem to work with class decorators, even on python 2.6. This makes the tests fail with a TypeError: Traceback (most recent call last): File "tornado/test/import_test.py", line 59, in test_import_twisted import tornado.platform.twisted File "tornado/platform/twisted.py", line 108, in <module> TornadoDelayedCall = implementer(IDelayedCall)(TornadoDelayedCall) File "/usr/lib/python2.6/dist-packages/zope/interface/declarations.py", line 496, in __call__ raise TypeError("Can't use implementer with classes. Use one of " TypeError: Can't use implementer with classes. Use one of the class-declaration functions instead. If we catch a typeerror while importing twisted, act like twisted is not installed.
Aug 11, 2012
In ioloop.add_timeout(), we still support adding timeouts using time.time(), but we actually convert them to time.monotonic() before running. If you don't explicitly set monotonic=False when calling add_timeout(), you'll get a warning when that happens. But mostly, you should really be passing in a datetime.timedelta object, because almost always you want to use relative time instead of absolute time.