Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

HTTPConnection: different (differentiated) timeout errors for connect and communication #609

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
1 participant

sanyi commented Oct 10, 2012

  1. Duplicated _on_timeout with _on_connect_timeout.
    _on_connect_timeout is triggered by connect timeout, this way we are
    able to differentiate connection timeout from communication timeout.

Should work with anything the original version worked.

  1. Due problems keeping multiple big HTTPRequest POST request body i introduced the ability to fill this body in a callback, from a file for example.

sanyi and others added some commits Oct 10, 2012

Update tornado/simple_httpclient.py
Duplicated _on_timeout with _on_connect_timeout.
_on_connect_timeout is triggered by connect timeout, this way we are 
able to differentiate connection timeout from communication timeout. 

Should work with anything the original version worked.
+added the ability to "stream" AsyncHTTPClient's body by setting torn…
…ado.httpclient.HTTPRequest's contentCallback and contentLength

 example usage: https://gist.github.com/3938021

@sanyi sanyi closed this Jan 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment