Python 3.3 patch #634

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@ghost

ghost commented Nov 12, 2012

When I trying to to auth an user I get an KeyError in python3.3.

dmchstudio added some commits Nov 12, 2012

Python 3.3 patch
When I trying to to auth an user I get an KeyError in python3.3.
Owner

bdarnell commented Nov 17, 2012

You can't just try/catch a SyntaxError like that. The right fix is to use the tornado.util.b function to get bytes on all versions of python. I also added a test and found that I needed to coerce the byte string back to a native string to get it working.

@bdarnell bdarnell closed this in e7485f8 Nov 17, 2012

bdarnell added a commit that referenced this pull request Nov 25, 2012

Fix TwitterMixin on Python 3.
Also add tests, and add get_auth_http_client method to all auth mixins.

Closes #634.

Conflicts:
	tornado/test/auth_test.py
	website/sphinx/releases/next.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment