Wait for bootstrap better, with fixup #14
Merged
Conversation
The regex was almost right, but it required a space after the percent symbol. In reality, this space should only be there when there is a keyword following. Part of 22132.
Previously, if you said wait_for_bootstrap, it would tell you if a node wasn't bootstrapped, but wouldn't help you notice whether it was crashed or running.
This tweak makes us capture _only_ the status keyword, rather than the keyword plus its surrounding parentheses and space.
Two problems here:
- The node status that we report on failure was not the same as
the most recent status that we checked. This meant that we
could declare that we weren't bootstrapped, while declaring
that every node was bootstrapped
- In addition to sleeping between the bootstrap checks, we also
slept after our final bootstrap check. This would increase
the likelihood of hitting the first bug above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.
The text was updated successfully, but these errors were encountered: