Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bidi #28

Merged
merged 15 commits into from Jun 20, 2019
Merged

Bidi #28

merged 15 commits into from Jun 20, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nmathewson @teor2345 @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented May 10, 2019

No description provided.

nmathewson added 15 commits May 9, 2019
@nmathewson
Don't capture all AttributeErrors in tests
87521c4 
There are all kinds of possible attribute errors that we would like
to report to the developer.
@nmathewson
Refactor Traffic.py to use asyncore and asynchat
b90ff42 
This refactor probably leaves a lot of needless pieces in place; I
tried to do only what was necessary to move away from a raw select()
loop.  Nonetheless, I think it simplifies things a bit.

(We can't use asyncio yet since we're keeping compatibility with
older pythons.)
@nmathewson
Fix up chutney verifier's notion of a test suite
f04f297 
Previously we counted the number of successes and failures, and
compared them to the number of expected tests.  That's fragile, if
we forget to count a test or if we count a success more than once.
Now we give every test a name, and we only allow tests to succeed or
fail once.
@nmathewson
Refactor Source and Sink to not know about their data
1bbe207 
Now data is generated by a DataSource type, and consumed by a
DataChecker type that compares its incoming data against the data
in a DataSource.
@nmathewson
Store the canonical DataSource in the TrafficTester.
b9668e4
@nmathewson
Make TrafficTester create sources and sinks
58c5a3c 
We'd like to be able to change the client and responder behavior,
but we need to keep both parts synchronized as we do so.
@nmathewson
Make chutney bidirectional by default
36a3ee8 
The default client/responder pair is no longer source/sink, but
echoclient/echoserver.
@nmathewson
re-add not-connected to handle some failure cases
4c0e3f3
@nmathewson
Don't use "ord" to debug a byte; python3 hates it.
8c8cbf5
@nmathewson
Don't check whether we can write on a listener
0687600
@nmathewson
Log test status less frequently: travis thinks it is too verbose.
c518444
@nmathewson
Use a separate asyncore socketmap for every TrafficTester
494f3fc 
This should prevent multiple in-process runs from interfering
@nmathewson
Be a little more verbose about test success/failure
eedc7e5 
Additionally, give them nicer unique names, and warn if we
accidentally double-add a test or something.
@nmathewson
Give each test a status, so we know what has gotten stuck where
bd2c604
@nmathewson
Stop trying to use half-open connections: Tor doesn't support them
15dcdee
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Jun 12, 2019

Closing and re-opening to get a new master merge and CI.

@teor2345 teor2345 closed this Jun 12, 2019
@teor2345 teor2345 reopened this Jun 12, 2019
@torproject-pusher torproject-pusher merged commit 15dcdee into torproject:master Jun 20, 2019
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment