Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated usage comments in 'bootstrap-network.sh' #47

Merged
merged 1 commit into from Jan 24, 2020
Merged

Updated usage comments in 'bootstrap-network.sh' #47

merged 1 commit into from Jan 24, 2020

Conversation

Labels
None yet
Projects
None yet
2 participants
@stevenengler
Copy link
Contributor

@stevenengler stevenengler commented Jan 22, 2020

See ticket #33023.

The usage comment says the following:

# Usage:
#    tools/bootstrap-network.sh [network-flavour]
#    network-flavour: one of the files in the networks directory,
#                     (default: 'basic')

but the actual code says the following:

# Set the variables for the chutney network flavour
export NETWORK_FLAVOUR=${NETWORK_FLAVOUR:-"bridges+hs-v2"}
[ -n "$1" ] && { NETWORK_FLAVOUR=$1; shift; }
export CHUTNEY_NETWORK="$CHUTNEY_PATH/networks/$NETWORK_FLAVOUR"

As you can see, the comments say that the default network is 'basic', but the code actually starts 'bridges+hs-v2'.

The usage comment now correctly describes the default network
flavour started by the script.
@torproject-pusher torproject-pusher merged commit 633f374 into torproject:master Jan 24, 2020
1 check passed
@stevenengler stevenengler deleted the ticket-33023 branch Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment