New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket 33304 - Return None for pid when pid file is empty #52

Merged

1 commit merged into torproject:master from stevenengler:ticket-33304

Feb 13, 2020

Contributor

stevenengler commented Feb 13, 2020

See ticket #33304.

In the getPid() function, Chutney reads the pid from a file and converts it to an integer.
if not os.path.exists(pidfile):
    return None

with open(pidfile, 'r') as f:
    return int(f.read())
This can result in the following error:
ValueError: invalid literal for int() with base 10: ''


          Ticket 33304 - Return None for pid when pid file is empty

185852f

ghost merged commit 185852f into torproject:master

stevenengler deleted the ticket-33304 branch

February 17, 2020 16:48

This pull request was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment