Skip to content
This repository has been archived by the owner. It is now read-only.

Stop deleting the latest.v3bw symlink. Instead, do an atomic rename. #237

Merged
merged 1 commit into from Jul 23, 2018

Conversation

Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Jul 18, 2018

Also:

  • document the location of latest.v3bw
  • document the atomic creation of latest.v3bw
  • explain how to atomically create latest.v3bw when transferring it to
    another host

Closes tor trac 26740.

For an explanation of the code changes, see the comments, or the second (atomic) answer on:
https://stackoverflow.com/questions/8299386/modifying-a-symlink-in-python

Also:
* document the location of latest.v3bw
* document the atomic creation of latest.v3bw
* explain how to atomically create latest.v3bw when transferring it to
  another host

Closes tor trac 26740.
@juga0
Copy link
Contributor

@juga0 juga0 commented Jul 18, 2018

lgtm

@juga0
Copy link
Contributor

@juga0 juga0 commented Jul 21, 2018

should i merge this?

@pastly
Copy link
Member

@pastly pastly commented Jul 21, 2018

If you've run sbws juat enough to test that it works as intended, feel free to merge. Thanks

@juga0
Copy link
Contributor

@juga0 juga0 commented Jul 23, 2018

tested

@juga0 juga0 merged commit 2b11135 into torproject:master Jul 23, 2018
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.