Ticket27341

[juga0]

sbws install doc is confusing

[pastly]

See inline comments. They contain the only things that need to change for me to merge this PR.

---

Please don't make so many commits with the same message. All the "Add term used in the specification" commits could be the same commits. The "And remove it from README" commits should be combined with whatever they're referencing.

If you are doing this because I wrote "Strive to write many small commits each containing an atomic change instead of one large mega-commit." in CONTRIBUTING, this is swinging too far towards tiny commits. What that sentence is trying to avoid is mega commits where feature X is implemented, bugs Y and Z are fixed, and unrelated typos in documentation are fixed all in the same commit. It's trying to encourage feature X getting a commit, two commits for each of the bug fixes, and a commit for the typo fixes. Taking 10 commits to move documentation from one file to another and freshen it up is almost as bad as that above hypothetical mega-commit.

[pastly]

It also needs to support Range headers, which both apache and nginx do. https://developer.mozilla.org/en-US/docs/Web/HTTP/Range_requests

[pastly]

"localion" --> "location"

The only statement that is true here is that the file can be in any location if you use -c. If users want sbws to automatically find their config, they should not put it in ~/.sbws (how it used to be), they should place it at ~/.sbws.ini. Please remove the /etc/sbws line until the sbws debian package actually exists and locations are actually decided.

[pastly]

We no longer support automatically adding /sbws.bin as of ca37185#diff-8749426703045cfdcbbffb59a8a091b3

[pastly]

"meanwhile" --> "meantime"

[pastly]

".[doc]" --> ".[test]", see setup.py

[pastly]

.rst wants `` not ` for "code" formatting. This would work in markdown.

[pastly]

.rst wants `` not ` for "code" formatting. This would work in markdown.

[pastly]

.rst wants `` not ` for "code" formatting. This would work in markdown.

[juga0]

f you are doing this because I wrote "Strive to write many small commits each containing an atomic change instead of one large mega-commit." in CONTRIBUTING

Yes, and i started to liked :)

See #215 (comment). I've not contributed to CONTRIBUTING to focus on having a MVP.

I'm not usually happy with my commit messages, but it would be hard to accept any contribution from me if "nice" commit messages are required from me.