Skip to content
This repository has been archived by the owner. It is now read-only.

Remove default values from help strings #262

Closed
wants to merge 1 commit into from
Closed

Remove default values from help strings #262

wants to merge 1 commit into from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@pastly @juga0
@pastly
Copy link
Member

@pastly pastly commented Oct 5, 2018

Because

  1. They might become incorrect if the constants change in the future
  2. (The main reason) They are already printed because the argparser is
    an ArgumentDefaultsHelpFormatter type
@pastly
Remove default values from help strings
246a268 
Because

1. They might become incorrect if the constants change in the future
2. (The main reason) They are already printed because the argparser is
an ArgumentDefaultsHelpFormatter type
@juga0
Copy link
Contributor

@juga0 juga0 commented Oct 8, 2018

Fixed by #265

@juga0 juga0 closed this Oct 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.