This repository has been archived by the owner. It is now read-only.
Make sbws actually read user-specified config if given #306
Conversation
juga0
suggested changes
Dec 7, 2018
sbws/util/config.py
Outdated
| @@ -70,7 +70,8 @@ def _get_user_config(args, conf=None): | |||
| # sbws should start with a logger before reading configurations. | |||
| print('Configuration file %s not found, using defaults.' % | |||
| args.config) | |||
| return _extend_config(conf, args.config) | |||
I think it would be more clear if you return conf in the if
Suggested change
| return _extend_config(conf, args.config) | |
| return conf |
| @@ -70,7 +70,8 @@ def _get_user_config(args, conf=None): | |||
| # sbws should start with a logger before reading configurations. | |||
| print('Configuration file %s not found, using defaults.' % | |||
| args.config) | |||
| return _extend_config(conf, args.config) | |||
| else: | |||
i think it would be more clear if instead of else you return _extend_config here
Suggested change
| else: | |
| return _extend_config(conf, args.config) |
It would also cause us to try to read a file that doesn't exist.
No when the return conf in #306 (comment) is applied first
|
Two commits to change to lines seems excesive to me |
|
There's a test not finished, and would be great to add more tests for all the cases |
|
Closing in favor of #326 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.
The text was updated successfully, but these errors were encountered: