Skip to content
This repository has been archived by the owner. It is now read-only.

Bug29295 #331

Merged
merged 6 commits into from Feb 15, 2019
Merged

Bug29295 #331

merged 6 commits into from Feb 15, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@juga0
@juga0
Copy link
Contributor

@juga0 juga0 commented Feb 6, 2019

No description provided.

juga0 added 6 commits Feb 6, 2019
@juga0
circuitbuilder: Stop building the circuit 3 times
4642c10 
It is observed that when the circuit can not be built the first
time, consecutive attemps will also fail.
The relay will be measured anyway in the next iteration.
This will also speed up the scanner.
There is no need to remove the 3 attemps in Destination.
_perform_usability_test, since the method will be removed in #28897.

Fixes bug #29295. Bugfix v0.1.0.
@juga0
circuitbuilder: circuit path is not a number in the code
851401b 
There is no any case in our code where path is an integer.
Remove asserts, check only the lenght of the circuit and check it
in a more logical way.
@juga0
circuitbuilder: Stop raising exception on path invalid.
0773f09 
Instead, return the reason why the circuit could not be built,
as other errors do.
@juga0
circuitbuilder: return reasons on circuit build errors
a4aa5e7
@juga0
circuitbuilder: add comment about future refactor
b6c6775
@juga0
tests: add circuitbuilder build_circuit test
5105313
@juga0 juga0 merged commit 5105313 into torproject:master Feb 15, 2019
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.