Skip to content
This repository has been archived by the owner. It is now read-only.

Ticket29299 squashed rebased #338

Merged
merged 9 commits into from Feb 28, 2019
Merged

Ticket29299 squashed rebased #338

merged 9 commits into from Feb 28, 2019

Conversation

Reviewers

@tlyu tlyu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@juga0 @tlyu
@juga0
Copy link
Contributor

@juga0 juga0 commented Feb 26, 2019

No description provided.

@juga0 juga0 mentioned this pull request Feb 26, 2019
Closed
tlyu
tlyu reviewed Feb 26, 2019
View changes
Copy link

@tlyu tlyu left a comment

Recommendation about not using 00, and a minor formatting note.

docs/source/man_sbws.ini.rst Outdated Show resolved Hide resolved
sbws/core/scanner.py Outdated Show resolved Hide resolved
juga0 added 4 commits Feb 27, 2019
@juga0
scanner: log any exception raised by main_loop
88752c9 
before stopping the scanner.
@juga0
scanner: Substitute log message with constant
8bd6154 
when dumping stack.
@juga0
scanner: Log callback error traceback
8cbb730 
Since the exception happens in a thread, not the main process,
use print_traceback to print the traceback.
@juga0
scanner, destination: Log all possible exceptions
c4f502c 
that can happen from requests, so that they can later be stored in
a Result.
tlyu
tlyu reviewed Feb 27, 2019
View changes
sbws/core/scanner.py Outdated Show resolved Hide resolved
juga0 added 5 commits Feb 28, 2019
@juga0
config: Add country to scanner and destinations sections
92dea95 
To be able to add them to the bandwidth file so that we can
diversify the locations and/or know how the location affects the
bandwidth results.
@juga0
v3bwfile: Include scanner country in the headers
6fc0810
@juga0
destination: add function to parse countries
fe28190 
so that they can be reported in the bandwidth file headers.
@juga0
v3bwfile: include destinations' country in headers
61f2ba8 
Closes: #29299.
@juga0
tests: Add country to the user configuration
878e21e 
used to run the scanner.
The test that runs the scanner was introduced by #28788.
@juga0 juga0 force-pushed the ticket29299_squashed_rebased branch from d561645 to 878e21e Feb 28, 2019
@juga0
Copy link
Contributor Author

@juga0 juga0 commented Feb 28, 2019

Squashed and force pushed

@juga0 juga0 merged commit 878e21e into torproject:master Feb 28, 2019
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.