Skip to content
This repository has been archived by the owner. It is now read-only.

Bug28897 squashed rebased #339

Merged
merged 5 commits into from Feb 27, 2019
Merged

Bug28897 squashed rebased #339

merged 5 commits into from Feb 27, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@juga0 @teor2345
@juga0
Copy link
Contributor

@juga0 juga0 commented Feb 26, 2019

No description provided.

juga0 added 5 commits Feb 26, 2019
@juga0
destination: stop running twice usability tests
d33ac8f 
in every measurement.
This removes the need for an extra lock for every measurement
It should also not be depending on a time interval, but on the
number of failures detected.
Not counting number of failures since it would need to modify the
destination or list of at runtime. It should be done in a future
refactor.

Fixes bug #28897. Bugfix v0.3.0
@juga0
destination: record consecutive failures
84e5d82 
Add methods to store consecutive destination failures and retrieve
the destinations that are still functional.
Since destinations can fail because of Tor circuits, it's not count
individual failures but consecutives one.
Also exit with error if there are no functional destinations left.
The maximum number of consecuitve failures is set to 10, but it
may need to be changed depending on the percentage of circuits and
requests that fail.
@juga0
destination: remove unused code
883307b
@juga0
scanner: stop threads when there're not destinations
3fe64b0 
Exit the scanner with error stoping threads first when there is not
any functional destination, since the destinations can not be recovered.
After merging #28897, `stop_threads` can be used (instroduced in #28869).
@juga0
tests: CB.build_circuit now returns a tuple
54c5db0 
Change tests added in #28897 with the changes introduced in #28736.
@juga0 juga0 mentioned this pull request Feb 26, 2019
Closed
@juga0
Copy link
Contributor Author

@juga0 juga0 commented Feb 26, 2019

Two new commits to use changes introduced in master.

@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Feb 27, 2019

This seems fine to me.

@juga0 juga0 merged commit 54c5db0 into torproject:master Feb 27, 2019
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.